Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include additional redis keyword arguments #102

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

untari
Copy link
Contributor

@untari untari commented Jun 5, 2024

This pull request is to add redis keywords arguments, and it has been tested in the locally.

@mariobehling mariobehling requested review from norbusan and marcoag June 11, 2024 08:57
@it-tma-tri it-tma-tri mentioned this pull request Jun 12, 2024
@hongquan
Copy link
Member

Which page to test this? I can only found /control/ but it doesn't have WebSocket feature, whereas, by looking into settings.py, the redis_connection_kwargs is used for channel layer config, which belongs to WebSocket feature.

@mariobehling mariobehling requested a review from hongquan June 18, 2024 07:44
@untari
Copy link
Contributor Author

untari commented Jun 18, 2024

Which page to test this? I can only found /control/ but it doesn't have WebSocket feature, whereas, by looking into settings.py, the redis_connection_kwargs is used for channel layer config, which belongs to WebSocket feature.

Perform actions on the /control/ page that would trigger WebSocket communication (e.g., starting or stopping a stream, sending a message, etc.).
Then check the 'WebSocket' tab in the developer tools to see if messages are being sent and received.

@mariobehling
Copy link
Member

Thanks!

@mariobehling mariobehling merged commit 7e47034 into fossasia:development Jun 18, 2024
2 of 5 checks passed
@untari untari deleted the redis-keyword-arguments branch October 5, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants