Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Speakers to the default page list on the sidebar #187

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

odkhang
Copy link
Collaborator

@odkhang odkhang commented Aug 1, 2024

This PR closes/references issue #179 . It does so by:

  1. Update translation files for Arabic, French, Spanish, Ukrainian, Russian.
  2. Add default speakers page on sidebar if eventyay talk is connected. (similar with schedule page)

How has this been tested?

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

This pull request introduces a new feature by adding a default speakers page to the sidebar when the eventyay talk is connected. Additionally, it enhances the application by updating translation files for multiple languages, including Arabic, French, Spanish, Ukrainian, and Russian.

  • New Features:
    • Added a default speakers page to the sidebar if the eventyay talk is connected, similar to the schedule page.
  • Enhancements:
    • Updated translation files for Arabic, French, Spanish, Ukrainian, and Russian languages.

Copy link

sourcery-ai bot commented Aug 1, 2024

Reviewer's Guide by Sourcery

This pull request introduces new UI translations for Arabic, French, Spanish, Ukrainian, and Russian. It also adds a pop-up for first-time users to select their preferred language, which is then stored in local storage. Additionally, existing translations have been updated for improved accuracy. The sidebar now includes a link to the speakers' page.

File-Level Changes

Files Changes
webapp/src/locales/de.json
webapp/src/locales/pt_BR.json
webapp/src/locales/en.json
Updated translations for German, Brazilian Portuguese, and English to include new UI elements and features.
webapp/src/locales/index.js
webapp/config.js
Added support for new languages: Arabic, French, Spanish, Ukrainian, and Russian.
webapp/src/components/profile/GreetingPrompt.vue
webapp/src/components/RoomsSidebar.vue
Enhanced UI components to include new features like language selection and speakers' page link.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@odkhang
Copy link
Collaborator Author

odkhang commented Aug 1, 2024

Hi @mariobehling, this PR depend on this PR: #187
So please review and merge it before this PR

image

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @odkhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -0,0 +1,430 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Consider lazy-loading translations to improve initial load times

With the addition of large JSON files for translations, consider implementing a lazy-loading mechanism for translations. This could help improve initial load times by only loading the necessary language data when required.

Suggested change
{
{
"App:disconnected-warning:text": () => import('./translations/ar.json').then(module => module.default["App:disconnected-warning:text"]),
"App:error-code:1006": () => import('./translations/ar.json').then(module => module.default["App:error-code:1006"]),

@@ -0,0 +1,430 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider having native speakers review the Russian translations for accuracy and cultural appropriateness.

Machine translations or direct copies from other languages may not capture nuances or cultural context. A review by native Russian speakers could significantly improve the quality of the localization.

Suggested change
{
{
"App:disconnected-warning:text": "Соединение потеряно! Пытаемся переподключиться…",
"App:error-code:1006": "Не удалось подключиться. Мы попробуем снова, но если проблема повторится, возможно, соединение блокируется брандмауэром вашей сети или VPN на вашем устройстве.",

"LandingPage:sessions:featured:link": "к полному расписанию",
"LandingPage:sessions:next:header": "Сессии скоро начнутся",
"LandingPage:sessions:next:link": "к полному расписанию",
"LandingPage:speakers:header": "Наши {{speakers}} спикеры",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Implement a more robust pluralization system to handle language-specific plural rules.

The current string interpolation may not handle plurals correctly for all languages. Consider using a pluralization library or implementing a system that can handle the complexities of different languages' plural rules.

Suggested change
"LandingPage:speakers:header": "Наши {{speakers}} спикеры",
"LandingPage:speakers:header": {
"one": "Наш спикер",
"few": "Наши {{count}} спикера",
"many": "Наши {{count}} спикеров",
"other": "Наши {{count}} спикеры"
}

@mariobehling
Copy link
Member

Please resolve conflicts.

@mariobehling mariobehling merged commit 824b3ef into fossasia:development Aug 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants