fix: Edit Profile Crashing and ScrollView in signup resolved #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcs10
changed the title
rcs10
changed the title
|
@iamareebjamal @dheerajkotwani can you review the above PR for the issue #2660 and #2609 |
dheerajkotwani
approved these changes
Jun 16, 2020
rcs10
commented
Jun 17, 2020
liveHarshit
suggested changes
Sep 12, 2020
| @@ -17,6 +17,7 @@ import org.fossasia.openevent.general.utils.AppLinkUtils | |||
| import org.fossasia.openevent.general.utils.Utils.navAnimGone | |||
| import org.fossasia.openevent.general.utils.Utils.navAnimVisible | |||
| import org.jetbrains.anko.design.snackbar | |||
| import org.koin.androidx.scope.BuildConfig | |||
There was a problem hiding this comment.
Why build config is required here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2660 and #2609
Changes: 1) added extra param ,Base64.NoWrap,in decodeBitmap of ImageUtils and also modifying the if condition in EditProfileFragment wrt issue #2660
2) changed the value of windowSoftInputMode to "adjustResize" wrt to issue #2609
Screenshots for the change:
Before:
After:(Scroll View being enabled when softkeyboard pops up)
After: (Edit Profile opens up without crashing)
