Skip to content

Conversation

@bhaveshAn
Copy link
Member

@bhaveshAn bhaveshAn commented May 25, 2018

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Fixes #63 Install deps and run app through Virtual Environment

Changes proposed in this pull request:

  • Update docs to install deps and run app through virtuelenv

Fixes #63 Install deps and run app through Virtual Environment

@SaptakS @niranjan94 Please review.

@ghost ghost added the needs-review label May 25, 2018
@ghost ghost assigned bhaveshAn May 25, 2018
@bhaveshAn bhaveshAn changed the base branch from development to master May 25, 2018 09:20
@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #64 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   74.48%   74.48%   -0.01%     
==========================================
  Files         230      230              
  Lines       15617    15617              
==========================================
- Hits        11633    11632       -1     
- Misses       3984     3985       +1
Impacted Files Coverage Δ
app/api/helpers/export_helpers.py 94.36% <0%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c638b...15462b9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants