Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time interval units issue solved. #2192

Closed
wants to merge 3 commits into from

Conversation

nsharmahack3r
Copy link

Fixes #[

#2188 . Note: This will automatically closes the issue.

Changes: [Add here what changes were made in this issue and if possible provide links.]

Screenshot/s for the changes: Screenshot_1612907455

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing: [feature.zip]

The text showing the unit was there but was not visible due to insufficient space.
@nsharmahack3r nsharmahack3r changed the title Patch 1 Time interval units issue solved. Feb 9, 2021
Copy link
Member

@asaikarthikeya asaikarthikeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the commits .

@nsharmahack3r
Copy link
Author

Hi I am new to open source. And by mistake, I closed the pull request instead of squashing. Will that cause trouble ?

@nsharmahack3r
Copy link
Author

How do I squash the commits ?

@CodeWithSouma
Copy link
Member

How do I squash the commits ?

please check the README on you can find how to git squash?

Copy link
Member

@CodeWithSouma CodeWithSouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CloudyPadmal
Copy link
Collaborator

We opt to do a make over. Closing this trivial fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants