Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time interval unit UI #2548

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Dishebh
Copy link
Member

@Dishebh Dishebh commented Sep 10, 2024

Fixes #2188

Changes

  • Fixes time interval Unit UI so it shows up correctly in portrait mode

Screenshots / Recordings

  • Landscape Mode
Screenshot 2024-09-10 at 11 12 02 PM
  • Portrait Mode
Screenshot 2024-09-10 at 11 12 23 PM

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Copy link

sourcery-ai bot commented Sep 10, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dishebh - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Dishebh
Copy link
Member Author

Dishebh commented Sep 10, 2024

cc @marcnause @AsCress

Copy link

github-actions bot commented Sep 10, 2024

Copy link
Contributor

@AsCress AsCress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dishebh Thank you very much for the PR and your work !
Here's a screenshot of the layout on my device:-

WhatsApp Image 2024-09-10 at 11 29 47 PM

I've added a suggestion as to how we can make this layout more flexible, to support more screen sizes.
Let me know how this sounds to you:))

@@ -94,7 +94,7 @@
android:layout_width="@dimen/width_zero"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:layout_weight="@dimen/weight_one" />
android:layout_weight="@dimen/weight_three" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, instead of updating the layout_weight, we could migrate the parent LinearLayout to a ConstraintLayout, which would better support a large number of screen sizes.

@marcnause marcnause self-requested a review September 20, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time interval units are not shown to the user.
3 participants