-
Notifications
You must be signed in to change notification settings - Fork 814
fix(macOS): mark AppIcon as template-rendering-intent to enable system tinting #2971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refines the Windows CI installer step by stripping out a missing Icelandic language include to prevent build failures, and updates the macOS AppIcon asset to use template-rendering-intent so the system can apply tinting. Entity relationship diagram for AppIcon asset Contents.json updateerDiagram
APPICON {
string filename
string size
string scale
string template_rendering_intent
}
APPICONSET {
string Contents_json
}
APPICONSET ||--o{ APPICON : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build StatusBuild successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/19210381492/artifacts/4512332754. Screenshots |
|
Hi, all checks have passed successfully ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Originally made while preparing for GSoC, now also considered as my pre-contribution for GirlScript Summer of Code (GSSoC 2025). |
|
Hello @Amitjoiya, thank you for your contributions. I don't think it is written down anywhere, but since we prefer to have an issue for each pull request, I have created and linked #2973 and #2974. We also like to have one pull request per issue. Since your pull request contains two commits which each contain a fix for one of the issues, merging it as it is will however result in a meaningful and comprehensible git history. Thank you again and welcome to PSLab! |
|
Thank you @marcnause and the PSLab team for reviewing and merging my PR 🙏 It was a great learning experience understanding the workflow and codebase of PSLab. My goal is to continuously contribute to FOSSASIA projects and hopefully be part of future programs like GSoC with the team 🚀 Thanks again for this opportunity! |







-1_instruments_screen.png?raw=true)
-2_nav_drawer.png?raw=true)
-3_accelerometer.png?raw=true)
-4_power_source.png?raw=true)
-5_multimeter.png?raw=true)
-6_wave_generator.png?raw=true)
-7_oscilloscope.png?raw=true)
Fixes: #2973, #2974
fix(macOS): mark AppIcon as template-rendering-intent to enable system tinting
Summary by Sourcery
Enhancements:
Summary by Sourcery
Enable system tinting on macOS by marking the AppIcon asset as a template and harden the Windows build pipeline by stripping out a missing language include in the installer script
Enhancements:
Build: