Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create reponsive multicard layout home screen #565

Merged
merged 1 commit into from
Jun 13, 2020
Merged

create reponsive multicard layout home screen #565

merged 1 commit into from
Jun 13, 2020

Conversation

priyanshunayan
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Feature implementation
  • Doc updates

Sid911
Sid911 approved these changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@Sid911 Sid911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

adityastic
adityastic requested changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be on the leading side. Please center the layout

@Dishebh
Copy link
Member

Dishebh commented Jan 28, 2020

@priyanshunayan any progress on this one?

@priyanshunayan
Copy link
Member Author

priyanshunayan commented Jan 28, 2020 •
edited
Loading

You can take up this issue if you want. :)

@Dishebh
Copy link
Member

Dishebh commented Jan 29, 2020

@priyanshunayan the project is throwing some errors for me, when I run it locally. So, to solve those I have opened some PRs. As soon as they get merged, I would take this issue. Thanks

orangecms
orangecms approved these changes Jun 13, 2020
View reviewed changes
Copy link
Collaborator

@orangecms orangecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks a lot :)

@orangecms orangecms merged commit 4e83482 into fossasia:development Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityastic adityastic adityastic requested changes

@Sid911 Sid911 Sid911 approved these changes

@orangecms orangecms orangecms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home Screen: Show Instrument Tiles in responsive way depending on screen size
5 participants
@priyanshunayan @Dishebh @orangecms @adityastic @Sid911