appengine: Remove app only from runtime part #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove app components only from the runtime part, i.e. docker store and compose project in the appengine->remove() call, and leave its content in the OCI/blob store as it can be needed during rollback or if a given app is listed in the `reset_apps`. After successful update unused blobs are removed from the blob stores, which guarantees proper app removal if it is not listed in `reset_apps`. Signed-off-by: Mike Sul <[email protected]>
|
@detsch This is the same commit we merged into the v94 branch yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove app components only from the runtime part, i.e. docker store and compose project in the appengine->remove() call, and leave its content in the OCI/blob store as it can be needed during rollback or if a given app is listed in the
reset_apps.After successful update unused blobs are removed from the blob stores, which guarantees proper app removal if it is not listed in
reset_apps.