Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libaktualizr-posix: asn1-cer.h needs cstdint #64

Closed
wants to merge 1 commit into from

Conversation

quaresmajose
Copy link
Member

fix build with gcc

| /srv/oe/build/tmp-lmp/work/cortexa57-lmp-linux/aktualizr/1.0+gitAUTOINC+257511849d-7/git/aktualizr/src/libaktualizr-posix/asn1/asn1-cer.h:56:1: error: 'uint8_t' does not name a type
|    56 | uint8_t cer_decode_token(const std::string& ber, int32_t* endpos, int32_t* int_param, std::string* string_param);
|       | ^~~~~~~
| /srv/oe/build/tmp-lmp/work/cortexa57-lmp-linux/aktualizr/1.0+gitAUTOINC+257511849d-7/git/aktualizr/src/libaktualizr-posix/asn1/asn1-cer.h:5:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

fix build with gcc

| /srv/oe/build/tmp-lmp/work/cortexa57-lmp-linux/aktualizr/1.0+gitAUTOINC+257511849d-7/git/aktualizr/src/libaktualizr-posix/asn1/asn1-cer.h:56:1: error: 'uint8_t' does not name a type
|    56 | uint8_t cer_decode_token(const std::string& ber, int32_t* endpos, int32_t* int_param, std::string* string_param);
|       | ^~~~~~~
| /srv/oe/build/tmp-lmp/work/cortexa57-lmp-linux/aktualizr/1.0+gitAUTOINC+257511849d-7/git/aktualizr/src/libaktualizr-posix/asn1/asn1-cer.h:5:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

Signed-off-by: Jose Quaresma <[email protected]>
@pattivacek
Copy link

This was fixed upstream FYI. :)

@quaresmajose
Copy link
Member Author

This was fixed upstream FYI. :)

With the clang toolchain it is ok but gcc don't like it very much.

@pattivacek
Copy link

With the clang toolchain it is ok but gcc don't like it very much.

I don't think I understand. The PRs are the same except for the include ordering.

@quaresmajose
Copy link
Member Author

With the clang toolchain it is ok but gcc don't like it very much.

I don't think I understand. The PRs are the same except for the include ordering.

We don't see it before because we use the clang toolchain in lmp.
This PR can be closed in favor of the one you mention backporting it, I will defer for the maintainer.

And thanks for pointing the upstream fix ;)

@mike-sul
Copy link

@detsch Please, cherry-pick this upstream commit uptane/aktualizr@05b1af5 to our current branch (2023.08+fio).

@pattivacek
Copy link

Why not rebase? :)

@mike-sul
Copy link

Why not rebase? :)

Maybe next month a bit busy atm :).

@detsch
Copy link
Member

detsch commented Aug 14, 2023

@quaresmajose I've cherry-picked the fix from upstream. Fix will be included in aktualizr-lite as well soon. You can close this PR.

@mike-sul mike-sul closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants