Rework device subcommand and client APIs to support lookup by UUID
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just part of our long term goal of making client.go smaller Signed-off-by: Andy Doan <[email protected]>
This will allow us to later on make our CLI work with either UUID or names. It also makes the APIs a little more segregated and easier to read. Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
vkhoroz
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Overall, good job.
It is a bit extra-ordinary, but in the end a really clever way to implement this.
My only comments are called to make the commit chain more refined.
Why? It was a pleasure to review this up until the last 2 commits...
...Up until that point I had a feeling that everything evolves gradually, hence is under control.
...The one before last commit is a kind of an overhaul of these nice intermediate commits which IMHO could be avoided by changing the commit order.
Ha - you caught me. I had a completely clear vision of the clean ups and then on the last two was sort of feeling my way through the dark. I'll clean that up. |
Signed-off-by: Andy Doan <[email protected]>
We deprecated this in 2021. Should be safe now. Signed-off-by: Andy Doan <[email protected]>
The commits following this will allow showing a device using its device UUID. This means the name attribute will become important. Signed-off-by: Andy Doan <[email protected]>
The changes that follow this will need a consistent way to determine the device it should target its operations against. This change makes a single place to look the device up from. Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of changes ultimately moves fioctl to support device commands where
they can be addressed by UUID instead of name. e.g.:
To get there I cleaned up the client APIs to make this more organized and support
a "device api". This separates a
Deviceobject - which requires a device lookupfrom a
DeviceApiwhich can make API calls w/o looking up a device.