feat: support getAccount mode #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
May 21, 2025
| let resp = tokio::try_join!(balance, nonce, code).map_err(Into::into); | ||
| (resp, address) | ||
| match mode.load(Ordering::Relaxed) { | ||
| ACCOUNT_FETCH_UNCHECKED | ACCOUNT_FETCH_SUPPORTS_ACC_INFO => { |
There was a problem hiding this comment.
we need to treat the initial unchecked case a bit differently, because we want to fetch as fast as possible so for this we should also request the regular acc request triple
Comment on lines
+302
to
+303
| if mode.load(Ordering::Relaxed) == ACCOUNT_FETCH_UNCHECKED { | ||
| mode.store(ACCOUNT_FETCH_SUPPORTS_ACC_INFO, Ordering::Relaxed); |
There was a problem hiding this comment.
these checks can be a bit optimized if we store the initial load in a tmp var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #47