Skip to content

fix(fmt): always return formatted when source read from stdin #11876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix(fmt): always return formatted when source read from stdin #11876

merged 1 commit into from
Sep 30, 2025

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Sep 29, 2025 •
edited
Loading

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy marked this pull request as ready for review September 29, 2025 17:36
DaniPopes
DaniPopes reviewed Sep 29, 2025
View reviewed changes
@grandizzy grandizzy marked this pull request as draft September 29, 2025 18:44
@grandizzy grandizzy changed the title fix(fmt): write file only if formatted, lock write fix(fmt): return file if source read from stdin Sep 30, 2025
@grandizzy grandizzy changed the title fix(fmt): return file if source read from stdin fix(fmt): return original if no diff when source read from stdin Sep 30, 2025
@grandizzy grandizzy requested a review from DaniPopes September 30, 2025 08:18
@grandizzy grandizzy marked this pull request as ready for review September 30, 2025 08:18
0xrusowsky
0xrusowsky previously approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xrusowsky
0xrusowsky reviewed Sep 30, 2025
View reviewed changes
@grandizzy grandizzy changed the title fix(fmt): return original if no diff when source read from stdin fix(fmt): always return formatted when source read from stdin Sep 30, 2025
@grandizzy grandizzy merged commit 4a2ad17 into foundry-rs:master Sep 30, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 30, 2025
@grandizzy grandizzy deleted the issue-11871 branch September 30, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@0xrusowsky 0xrusowsky 0xrusowsky approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatter integration in VS Code is broken (with latest nightly)
4 participants
@grandizzy @onbjerg @DaniPopes @0xrusowsky