refactor(forge): Deduplicate special function validation logic #12108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjl10
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request refactors the
ContractRunnerto eliminate duplicated code for validatingsetUpandafterInvariantfunctions within therun_testsmethod.Changes
Extracted a new helper function: A new private method,
validate_special_function, has been introduced. This function now encapsulates the shared logic for:setUp) is defined.Simplified
run_tests: The main test running function now calls this new helper, making the control flow cleaner and more readable.Reasoning
This refactoring adheres to the DRY (Don't Repeat Yourself) principle, which significantly improves code maintainability. By centralizing the validation logic, we make it easier to modify in the future and reduce the chance of introducing bugs.