Skip to content

Conversation

DaniPopes
Copy link
Member

Merge group status checks are reported on push. I believe there is no point in re-running everything again after the merge group is committed.

We only need to run docs to publish rustdoc to GH Pages.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the CI workflow to avoid redundant job runs after merge group commits, as status checks are already reported during the merge group phase. The primary changes extract the docs job into a reusable workflow that runs on push to master for GitHub Pages deployment, while other CI jobs now only trigger on pull requests and merge groups.

  • Removes push trigger from main CI workflow
  • Extracts docs job into a separate reusable workflow that runs on push to master
  • Updates workflow name from "nextest" to "test"

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yml Removes push trigger, refactors docs job to call reusable workflow, updates CodeQL job name
.github/workflows/docs.yml New reusable workflow for building and deploying documentation to GitHub Pages
.github/workflows/test.yml Updates workflow name from "nextest" to "test"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Merge group status checks are reported on push. I believe there is
no point in re-running everything again after the merge group is
committed.
@DaniPopes
Copy link
Member Author

hmm

analyze (actions)
Unable to validate code scanning workflow: MissingPushHook
analyze (actions)
1 issue was detected with this workflow: Please specify an on.push hook to analyze and see code scanning alerts from the default branch on the Security tab.

@DaniPopes DaniPopes marked this pull request as draft October 21, 2025 14:00
@grandizzy
Copy link
Collaborator

maybe @zerosnacks pls chime in?

@DaniPopes
Copy link
Member Author

Maybe we need to update the configuration here? https://github.com/foundry-rs/foundry/security/code-scanning/tools/CodeQL/status/

@grandizzy
Copy link
Collaborator

grandizzy commented Oct 21, 2025

Maybe we need to update the configuration here? https://github.com/foundry-rs/foundry/security/code-scanning/tools/CodeQL/status/

I think is because the on push master is removed from ci.yml and needs to be on the default branch?

This warning means your GitHub Actions workflow is not configured to run code scanning on the default branch when a new commit is pushed.
To fix this, you need to add or modify the on.push trigger in your workflow file to include the default branch (e.g., main or master) so that security alerts are analyzed and appear in the Security tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants