-
Notifications
You must be signed in to change notification settings - Fork 2.2k
ci: don't run most CI on push #12230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the CI workflow to avoid redundant job runs after merge group commits, as status checks are already reported during the merge group phase. The primary changes extract the docs job into a reusable workflow that runs on push to master for GitHub Pages deployment, while other CI jobs now only trigger on pull requests and merge groups.
- Removes push trigger from main CI workflow
- Extracts docs job into a separate reusable workflow that runs on push to master
- Updates workflow name from "nextest" to "test"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
.github/workflows/ci.yml | Removes push trigger, refactors docs job to call reusable workflow, updates CodeQL job name |
.github/workflows/docs.yml | New reusable workflow for building and deploying documentation to GitHub Pages |
.github/workflows/test.yml | Updates workflow name from "nextest" to "test" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge group status checks are reported on push. I believe there is no point in re-running everything again after the merge group is committed.
886cb9b
to
b8c0718
Compare
hmm
|
maybe @zerosnacks pls chime in? |
Maybe we need to update the configuration here? https://github.com/foundry-rs/foundry/security/code-scanning/tools/CodeQL/status/ |
I think is because the on push master is removed from ci.yml and needs to be on the default branch? This warning means your GitHub Actions workflow is not configured to run code scanning on the default branch when a new commit is pushed. |
Merge group status checks are reported on push. I believe there is no point in re-running everything again after the merge group is committed.
We only need to run
docs
to publish rustdoc to GH Pages.