Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install missing deps on build #2617

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Aug 4, 2022

Motivation

It's nice

Solution

Use git submodule status to check if the project has submodules that have not been pulled. If there is, we pull them by calling forge install

Closes #2098 with the note that we should create a new issue for the discussion in there about #2386

@onbjerg onbjerg added the T-feature Type: feature label Aug 4, 2022
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice another git submodule fix

@onbjerg
Copy link
Member Author

onbjerg commented Aug 4, 2022

One day we will rid ourselves of git submodules...

@gakonst gakonst merged commit 54191b6 into master Aug 4, 2022
@gakonst gakonst deleted the onbjerg/forge-autoinstall branch August 4, 2022 16:57
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install (and download) missing dependencies automatically
3 participants