wip: forge script warns when calling eoa #5036
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Deployment scripts do not verify the existence of a contract before invoking its functions.
This can lead to challenges in determining the success or failure of a deployment script, as every call to an call to an externally owned accounts (EOAs) return a success flag,
For example, the script below will not issue an error when getting deployed and decodes the
setNum
calls as if they were regular function calls.Solution
Issue a warning when calling a address with available abi and no code deployed.