-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forge): isolated execution #7186
Merged
+460
−46
Merged
Changes from 20 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f771edc
[wip] feat(forge): isolated execution
klkvr 3bf3b3c
small fixes
klkvr 12ae30b
don't panic on transaction error + fixture fix
klkvr 2f94204
stricter call scheme check
klkvr 759a721
refactor and more fixes
klkvr 75899e6
wip
klkvr b59b450
Merge branch 'master' into klkvr/isolated-execution
klkvr 2633134
fix
klkvr 986cd10
wip
klkvr 9f10bae
wip
klkvr 408fb7f
rm cheatcodes check
klkvr f8f5107
clippy
klkvr 130b298
update commit logic
klkvr 934fb03
opt-in
klkvr af052a5
enable in gas reports
klkvr fb64f4f
--isolate
klkvr 2258409
isolation tests
klkvr 129470c
Merge branch 'master' into klkvr/isolated-execution
klkvr 87032a0
smaller diff
klkvr 71a4d74
fmt
klkvr 5c4a191
simplify logic
klkvr 313a57f
docs
klkvr 1869209
fmt
klkvr 18acadd
enable isolation properly for --gas-report
klkvr 33814e5
change nonce incrementing
klkvr 96b9688
document why we touch
klkvr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently we are increasing nonce before broadcasting CALL to simulate nonce increase during on-chain transaction
this is incorrect for
--isolate
because we need nonce to be up-to-date at the point when we are creating a transactionso the change is to increase nonce after the CALL
however, thinking of it now, with new workaround when we explicitly decrease nonces in isolation, this is not really needed as long as we touch the account when pre-increase its nonce, updated in 33814e5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah can we also doc that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call