(feat): accept ETH_RPC_URL env as fork-url alias #8972
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSandwich
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
|
The integration tests are a rabbit hole to fix. This PR isn't as simple as I was expecting and currently I don't have time to fix everything, so I'll return to it in a few days. |
|
related: #7755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently commands like
forge scriptdon't read theETH_RPC_URLenv variable, you need to toforge script --rpc-url "$ETH_RPC_URL"(or--fork-urlor-f,--rpc-urlis just one of the aliases). This is unlike all other commands likeforge create, which acceptETH_RPC_URLas the--rpc-urlalternative.Solution
Add support for
ETH_RPC_URLwherever--fork-urlis accepted.