fix(cast): try decoding custom errors when execution reverted in cast send #9794
+126
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
DaniPopes
reviewed
Jan 31, 2025
grandizzy
changed the title
DaniPopes
requested changes
Feb 4, 2025
crates/cast/bin/tx.rs
Outdated
|
|
||
| /// Helper function that tries to decode custom error name and inputs from error payload data. | ||
| async fn decode_execution_revert(data: &RawValue) -> Result<Option<String>> { | ||
| if let Some(err_data) = data.to_string().replace("\"", "").strip_prefix("0x") { |
There was a problem hiding this comment.
serde_json::from_value::<String is probably better
There was a problem hiding this comment.
changed to using serde_json::from_str::<String> in e9b5e66
crates/cast/bin/tx.rs
Outdated
| let mut decoded_error = known_error.name.clone(); | ||
| if !known_error.inputs.is_empty() { | ||
| decoded_error.push('('); | ||
| let error = known_error.decode_error(&hex::decode(err_data)?)?; |
There was a problem hiding this comment.
you should be able to do write!("({})", ...) with itertools .format(", ")
There was a problem hiding this comment.
changed in e9b5e66
mattsse
approved these changes
Feb 4, 2025
DaniPopes
approved these changes
Feb 4, 2025
DaniPopes
reviewed
Feb 4, 2025
crates/cast/bin/tx.rs
Outdated
| Ok(()) | ||
| } | ||
| Err(err) => { | ||
| if let TransportError::ErrorResp(ref payload) = err { |
zerosnacks
approved these changes
Feb 4, 2025
|
amazingggg, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
cast sendwith local artifacts #9789Solution