Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: data-transformer ambiguous enum #2872

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

test: data-transformer ambiguous enum #2872

wants to merge 3 commits into from

Conversation

khayss
Copy link
Contributor

@khayss khayss commented Jan 24, 2025

Closes #2553

Introduced changes

  • Add test for ambiguous enum to data-transformer.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@khayss
Copy link
Contributor Author

khayss commented Jan 24, 2025

This is a draft. I have some questions to continue with the issue.

@cptartur
Copy link
Member

Hey @khayss, what's the status of this? If you have questions please ask them here or in the telegram, https://t.me/starknet_foundry_support

If you are no longer working on the issue, please let us know so we can reassign.

@khayss
Copy link
Contributor Author

khayss commented Jan 27, 2025 •
edited
Loading

Hello @cptartur, I'm working on this. I already reached out on Telegram and will make updates soon.

@khayss
Copy link
Contributor Author

khayss commented Jan 29, 2025

Hey @cptartur
I have added the test. It's passing. Kindly review and let me know any changes to make or add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur Awaiting requested review from cptartur cptartur will be requested when the pull request is marked ready for review cptartur is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski will be requested when the pull request is marked ready for review ddoktorski is a code owner

@kkawula kkawula Awaiting requested review from kkawula kkawula will be requested when the pull request is marked ready for review kkawula is a code owner

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob will be requested when the pull request is marked ready for review franciszekjob is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests with ambiguous enum to data transformer
2 participants
@khayss @cptartur