Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove default_trait_access lint #2875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: remove default_trait_access lint #2875

wants to merge 1 commit into from
+26 −18

Conversation

ekumamatthew
Copy link

Closes #2775

Introduced changes

  • Remove -A clippy::default_trait_access from .cargo/config.toml
  • Replace Default::default() with Map::new() in configuration
  • Update clippy documentation

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

ddoktorski
ddoktorski requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. However, the changes submitted do not resolve the issue. Please revisit the issue details and update the pull request accordingly. Also, consider reviewing the default trait access documentation.

docs/src/development/environment-setup.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverse formatting changes made in this file, only lint command should be updated

crates/sncast/src/helpers/configuration.rs
Comment on lines +54 to +56
url: String::new(),
account: String::new(),
accounts_file: Utf8PathBuf::new(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect now, the default was used correctly here as it specified the types

@ddoktorski
Copy link
Contributor

@ekumamatthew any progress on this?

@ekumamatthew
Copy link
Author

Yes. Updating my pr shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski requested changes

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

@kkawula kkawula Awaiting requested review from kkawula kkawula is a code owner

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove clippy::default_trait_access from lint
2 participants
@ekumamatthew @ddoktorski