Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add specific directories to .gitignore #2880

Conversation

davidmelendez
Copy link
Contributor

@davidmelendez davidmelendez commented Jan 27, 2025

Add specific directories to .gitignore when calling snforge init #2298

Closes #2298

Introduced changes

The following folder references are added to the .gitignore in the new.rs located in crates/forge/src:

.snfoundry_cache/
file, "snfoundry_trace/
file, "coverage/
file, "profile/"

Additionally, a test is created to verify the changes in running.rs located in crates/forge/tests/e2e, the fn is called create_new_project_and_check_gitignore

Checklist

  • [X ] Linked relevant issue
  • Updated relevant documentation
  • [X ] Added relevant tests
  • [ X] Performed self-review of the code
  • Added changes to CHANGELOG.md

Copy link
Collaborator

@ksew1 ksew1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run cargo fmt before pushing

crates/forge/tests/e2e/running.rs Outdated Show resolved Hide resolved
crates/forge/tests/e2e/running.rs Outdated Show resolved Hide resolved
crates/forge/tests/e2e/running.rs Outdated Show resolved Hide resolved
crates/forge/tests/e2e/running.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ksew1 ksew1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add changes to CHANGELOG.md

CHANGELOG.md Show resolved Hide resolved
@cptartur cptartur requested a review from ksew1 January 29, 2025 14:22
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@ksew1 ksew1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200w

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: kkawula <[email protected]>
@davidmelendez
Copy link
Contributor Author

Hello, what happened with this?

@cptartur cptartur enabled auto-merge February 3, 2025 12:13
@cptartur cptartur added this pull request to the merge queue Feb 4, 2025
Merged via the queue into foundry-rs:master with commit 2e3aeea Feb 4, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add specific directories to .gitignore when calling snforge init
4 participants