Skip to content
This repository has been archived by the owner on Jun 17, 2023. It is now read-only.

Fix TRAMP regression #43

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Fix TRAMP regression #43

merged 1 commit into from
Jan 4, 2017

Conversation

dvzubarev
Copy link
Contributor

file-attributes accepts trampified paths, otherwise it looks for local files.

file-attributes accepts trampified paths, otherwise it looks for local files.
@fourier
Copy link
Owner

fourier commented Jan 4, 2017

Thanks, I don't use ztree over TRAMP so can't test.
@Silex does this fix works for you?

@Silex
Copy link
Contributor

Silex commented Jan 4, 2017

The fix looks correct. I see that you attempted to make TRAMP faster by checking the file size instead of doing the diff, but based on the latest comment in #18 it looks like it's still slow.

You'd really set up a test for this, that way you actually can measure differences and regressions.

The test would be fairly simple: have directory A and B (which is a copy of A with differences).

  • Test 1: assert ztree finds the corrects diffs between A and B (the diff can be a static list since it's setup).
  • Test 2: assert ztree finds the correct diff between A and B, but B sits on a remote server
  • Test 3: measure the time taken for the diff when B sits on a remote server and report it. That way you can test the commit impacts on performances.

Repeat and have 3-4 different A & B as input.

@fourier
Copy link
Owner

fourier commented Jan 4, 2017

Ok I'll accept the fix then.

@fourier fourier merged commit 87c9714 into fourier:master Jan 4, 2017
@fourier
Copy link
Owner

fourier commented Jan 4, 2017

Merged, thanks @dvzubarev !

@dvzubarev dvzubarev deleted the tramp-fix branch January 5, 2017 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants