Update PrefixIndexer.scala #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvandew
reviewed
Jul 13, 2018
| @@ -112,32 +112,36 @@ class PrefixIndexer( | |||
| if (index % 1000 == 0) { | |||
| log.info("done with %d of %d prefixes".format(index, numPrefixes)) | |||
| } | |||
| val records = getRecordsByPrefix(prefix, PrefixIndexer.MaxNamesToConsider) | |||
| try { | |||
There was a problem hiding this comment.
honest question: would it make sense to have this wrap just the getRecordsByPrefix call instead of the entire block here? I suppose any exception leaves you in the same broken state, but I'm not sure you would want to ignore every possible error here
|
|
||
| prefixWriter.append(prefix, fidsToCanonicalFids(fids.toList)) | ||
| } catch { | ||
| case e: Exception => println("Skipping due to error processing prefixes") |
There was a problem hiding this comment.
we should probably at least print the exception here as well, something like e.printStackTrace(System.err) maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address Issue #53 (#53), which has to do with regex parsing errors caused during processing of prefixes, I have wrapped this block of code in a try/catch. I am not a scala programmer, so this may not be the best implementation. However, if we do not contain regex errors related to prefix processing, the error bubbles up causing parsing to exit with an error, and the database/index is unusable. Therefore, I feel like its worthwhile to trap the error here, and just skip over processing errors. Submitting this for consideration/feedback. Perhaps it would be even better to trap the specific error identified in Issue #53, rather than trapping all errors.