Make PrimitiveRenderTypes correctly output long values with tests #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iantabolt
reviewed
Oct 5, 2018
| @@ -8,7 +8,12 @@ | |||
|
|
|||
| object ${baseName}Constants { | |||
| #for (const <- constants) | |||
| <% val value = const.valueOption.map{v => "val %s: %s = %s".format(const.name, const.renderType.text, v)} %> | |||
| <% val value = const.valueOption.map{v => { | |||
There was a problem hiding this comment.
I'm thinking we should move this higher up, either in ScalaConst.valueOption or better PrimitiveRenderType.renderValue. Is there ever a time where we don't want the L?
|
Thanks for this! Can you add a test? I think it would go in |
omrihq
changed the title
iantabolt
suggested changes
Oct 5, 2018
| @@ -9,6 +9,7 @@ class ScalaConstTest { | |||
| @Test | |||
| def testConstantGeneration(): Unit = { | |||
| A.assertEquals(List(1.2, 2.1, 1.1), ConstantineConstants.LISTCONST) | |||
| A.assertEquals(1000000000, ConstantineConstants.LONG) | |||
There was a problem hiding this comment.
This number is in range of integers so it doesn't confirm that the L worked. I think one more zero will do it (and then add the L so the test compiles)
|
Good catch, updated |
iantabolt
approved these changes
Oct 5, 2018
|
Patch was accepted and is live in Fsq.io. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #45