Excluding hadoop-lzo from ivy resolution #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateor
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Thanks for submitting the patch! We believe we have a fix ready to go out for the unrelated break in the CI.
We will ensure we have green HEAD and then apply your patch internally. Assuming the CI stays green, we will land it internally (preserving author credit) and then deploy to Fsq.io
|
Thanks for bearing with us as we landed this patch internally! This patch was accepted, the commit was included in today's Fsq.io update: f0db473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #62, com.hadoop.gplcompression.hadoop-lzo fails to resolve in some circumstances. It appears to be an internal twitter dependency that is not used by fsq.io. Corrected this issue by adding a global exclusion to pants.ini. Took several tries to get the org right.