Add review remarks

fox-it · Jul 18, 2024 · 40379dd · 40379dd
1 parent 6b19fb5
commit 40379dd
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/acquire/utils.py b/acquire/utils.py
@@ -328,14 +328,15 @@ def check_and_set_acquire_args(
     if not args.children and args.skip_parent:
         raise ValueError("--skip-parent can only be set with --children")
 
-    if args.output_type == "zip" and args.compress_method not in ZIP_COMPRESSION_METHODS:
-        raise ValueError(
-            f"Invalid compression method for zip, allowed are: {', '.join(ZIP_COMPRESSION_METHODS.keys())}"
-        )
-    if args.output_type == "tar" and args.compress_method not in TAR_COMPRESSION_METHODS:
-        raise ValueError(
-            f"Invalid compression method for tar, allowed are: {', '.join(TAR_COMPRESSION_METHODS.keys())}"
-        )
+    if args.compress:
+        if (args.output_type == "zip" and args.compress_method) and args.compress_method not in ZIP_COMPRESSION_METHODS:
+            raise ValueError(
+                f"Invalid compression method for zip, allowed are: {', '.join(ZIP_COMPRESSION_METHODS.keys())}"
+            )
+        if (args.output_type == "tar" and args.compress_method) and args.compress_method not in TAR_COMPRESSION_METHODS:
+            raise ValueError(
+                f"Invalid compression method for tar, allowed are: {', '.join(TAR_COMPRESSION_METHODS.keys())}"
+            )
 
 
 def get_user_name() -> str: