-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide PyOxidizer binaries #109
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 44.36% 44.60% +0.24%
==========================================
Files 26 26
Lines 3316 3394 +78
==========================================
+ Hits 1471 1514 +43
- Misses 1845 1880 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In the meanwhile, I updated the CI from the original PR in one of my repos and were successful in creating binaries: acquire-binaries. I'm mostly interested in the I hope this helps and is okay with you. |
This PR adds CI for building PyOxidizer binaries for Windows, macOS, Linux (GNU) and Linux (musl).
The Linux musl build currently depends on a forked PyOxidizer (https://github.com/fox-it/PyOxidizer/tree/esxi-compatibility) because of indygreg/PyOxidizer#725. The fork also includes a workaround for ESXi.
The Linux GNU build is built in a
manylinux2014
container to ensure an old libc version for compatibility.The macOS build combines a x86_64 and aarch64 binary into a single universal2 binary for compatibility on both Intel and Apple Silicon Macs.
A separate list of dependencies is currently maintained in
pyoxidizer.bzl
because there are no appropriate dependency bundles available in acquire right now.minio
is included for uploading to cloud storage, but unfortunatelypycryptodome
is not yet included. It should be possible to include it but I couldn't get it working across all OS variants right now, so that could be a future improvement. The way to go here is likely a filesystem fallback on an accompaniedlib
directory, but for some reason this broke the embeddedmsgpack
. PyOxidizer should also be able to recompile an extension into itself but I did not look into this yet.The
pyoxidizer.bzl
file also includes comments explaining how to build manually, as well as how you could modify the embedded configuration.Ideally we add these binaries as files into the releases, but I wasn't sure what the desired CI trigger would be for that, so I've put it on tags for now. For this reason, the PyOxidizer also currently downloads the latest stable
acquire
from PyPI instead of copying from the local source repository.