-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide PyOxidizer binaries #109
Open
Schamper
wants to merge
8
commits into
main
Choose a base branch
from
pyoxidizer-bins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 44.36% 44.60% +0.24%
==========================================
Files 26 26
Lines 3316 3394 +78
==========================================
+ Hits 1471 1514 +43
- Misses 1845 1880 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pyrco
requested changes
Nov 20, 2023
pyrco
reviewed
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CI for building PyOxidizer binaries for Windows, macOS, Linux (GNU) and Linux (musl).
The Linux musl build currently depends on a forked PyOxidizer (https://github.com/fox-it/PyOxidizer/tree/esxi-compatibility) because of indygreg/PyOxidizer#725. The fork also includes a workaround for ESXi.
The Linux GNU build is built in a
manylinux2014
container to ensure an old libc version for compatibility.The macOS build combines a x86_64 and aarch64 binary into a single universal2 binary for compatibility on both Intel and Apple Silicon Macs.
A separate list of dependencies is currently maintained in
pyoxidizer.bzl
because there are no appropriate dependency bundles available in acquire right now.minio
is included for uploading to cloud storage, but unfortunatelypycryptodome
is not yet included. It should be possible to include it but I couldn't get it working across all OS variants right now, so that could be a future improvement. The way to go here is likely a filesystem fallback on an accompaniedlib
directory, but for some reason this broke the embeddedmsgpack
. PyOxidizer should also be able to recompile an extension into itself but I did not look into this yet.The
pyoxidizer.bzl
file also includes comments explaining how to build manually, as well as how you could modify the embedded configuration.Ideally we add these binaries as files into the releases, but I wasn't sure what the desired CI trigger would be for that, so I've put it on tags for now. For this reason, the PyOxidizer also currently downloads the latest stable
acquire
from PyPI instead of copying from the local source repository.