Add optional boolean value to all store_true instances #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 43.39% 43.39%
=======================================
Files 26 26
Lines 3374 3374
=======================================
Hits 1464 1464
Misses 1910 1910
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Miauwkeru
force-pushed
the
DIS-3228_change-flags-to-boolean-optional-action
branch
from
5a92941
to
f77392f
Compare
Schamper
reviewed
Jul 10, 2024
acquire/utils.py
Outdated
| @@ -99,7 +99,7 @@ def create_argument_parser(profiles: dict, volatile: dict, modules: dict) -> arg | |||
| ) | |||
| parser.add_argument("--public-key", type=Path, help=argparse.SUPPRESS) | |||
| parser.add_argument("-l", "--log", type=Path, help="log directory location") | |||
| parser.add_argument("--no-log", action="store_true", help=argparse.SUPPRESS) | |||
| parser.add_argument("--no-log", action=argparse.BooleanOptionalAction, help=argparse.SUPPRESS) | |||
There was a problem hiding this comment.
How will this work? —no-no-log?
There was a problem hiding this comment.
that it would, I can look into how to invert the checks, or just skip the flags that already have --no or --disable in it.
acquire/utils.py
Outdated
| @@ -114,24 +114,28 @@ def create_argument_parser(profiles: dict, volatile: dict, modules: dict) -> arg | |||
| parser.add_argument("-d", "--directory", action="append", help="acquire directory recursively") | |||
| parser.add_argument("-g", "--glob", action="append", help="acquire files matching glob pattern") | |||
|
|
|||
| parser.add_argument("--disable-report", action="store_true", help="disable acquisition report file") | |||
| parser.add_argument( | |||
| "--disable-report", action=argparse.BooleanOptionalAction, help="disable acquisition report file" | |||
acquire/utils.py
Outdated
| help="upload result files after collection", | ||
| ) | ||
| parser.add_argument( | ||
| "--upload", | ||
| nargs="+", | ||
| help="upload specified files (all other acquire actions are ignored)", | ||
| ) | ||
| parser.add_argument("--no-proxy", action="store_true", help="don't autodetect proxies") | ||
| parser.add_argument("--no-proxy", action=argparse.BooleanOptionalAction, help="don't autodetect proxies") |
Miauwkeru
force-pushed
the
DIS-3228_change-flags-to-boolean-optional-action
branch
from
997a9d7
to
96d4f62
Compare
Poeloe
requested changes
Jul 18, 2024
Poeloe
requested changes
Jul 18, 2024
Miauwkeru
commented
Jul 18, 2024
Miauwkeru
force-pushed
the
DIS-3228_change-flags-to-boolean-optional-action
branch
from
5766d2f
to
1bd2f3e
Compare
Schamper
requested changes
Jul 18, 2024
Schamper
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.