-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent error messages involving output-file
#191
Conversation
9327a04
to
06b50b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 44.60% 44.60%
=======================================
Files 26 26
Lines 3394 3394
=======================================
Hits 1514 1514
Misses 1880 1880
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.gitignore
Outdated
|
||
# Ignore artefacts created by an acquire run in the package directory | ||
*.tar | ||
*.log | ||
*.report.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are only artifacts generate from where you run acquire. These do not need to be ignored as they are not build artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move these to my local exclude file.
Could you adjust the title of the PR to be a bit more informative of what it changes? And so it adheres to https://docs.dissect.tools/en/latest/contributing/style-guide.html |
output-file
Note: There are failing CI checks unrelated to this pr. After CI is fixed, this PR can be re-reviewed.
Make error messages concerning
output-file
consistent with the name of the flag.extra:
closes #169