Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquire device list #198

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Acquire device list #198

merged 3 commits into from
Oct 24, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-897)

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 47.09%. Comparing base (7177169) to head (1bdc2e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
acquire/acquire.py 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   47.07%   47.09%   +0.01%     
==========================================
  Files          26       26              
  Lines        3405     3421      +16     
==========================================
+ Hits         1603     1611       +8     
- Misses       1802     1810       +8     
Flag Coverage Δ
unittests 47.09% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Horofic Horofic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might it be a good idea to use the _windows_get_devices() and co functions in dissect.target's local loader (loader.py)? https://github.com/fox-it/dissect.target/blob/main/dissect/target/loaders/local.py#L337C1-L337C28

Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cecinestpasunepipe cecinestpasunepipe merged commit 6266553 into main Oct 24, 2024
16 of 20 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-897 branch October 24, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants