Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vista idlist parsing #25

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Fix Vista idlist parsing #25

merged 6 commits into from
Jan 30, 2024

Conversation

Horofic
Copy link
Contributor

@Horofic Horofic commented Jan 25, 2024

(DIS-2798)

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0e19fdd) 69.20% compared to head (a1e9f31) 70.52%.

Files Patch % Lines
dissect/shellitem/lnk/lnk.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   69.20%   70.52%   +1.32%     
==========================================
  Files           4        4              
  Lines         302      302              
==========================================
+ Hits          209      213       +4     
+ Misses         93       89       -4     
Flag Coverage Δ
unittests 70.52% <37.50%> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a regression test for this change?

dissect/shellitem/lnk/lnk.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@Horofic Horofic merged commit 4e25899 into main Jan 30, 2024
29 of 30 checks passed
@Horofic Horofic deleted the DIS-2798_fix-lnk-parsing branch January 30, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants