-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistency of target.ips output #870
base: main
Are you sure you want to change the base?
Conversation
Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints. |
Co-authored-by: Erik Schamper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the broken suggestion 😄 would it be possible to make a regression test too?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
- Coverage 76.65% 76.64% -0.01%
==========================================
Files 316 316
Lines 27101 27092 -9
==========================================
- Hits 20774 20766 -8
+ Misses 6327 6326 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Couldn't figure out how to properly modify a VirtualHive in a way the RegistryPlugin registers multiple ControlSets. Perhaps you know of a better way @Schamper? |
We can further simplify the general network plugin when fox-it/flow.record#148 is merged. |
This is now ready for review. |
Co-authored-by: Erik Schamper <[email protected]>
Fixes #877.