Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular imports during loader registration #911

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Fix circular imports

2c2e2e5
Select commit
Loading
Failed to load commit list.
Open

Fix circular imports during loader registration #911

Fix circular imports
2c2e2e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 17, 2024 in 0s

76.60% (-0.05%) compared to cb69261

View this Pull Request on Codecov

76.60% (-0.05%) compared to cb69261

Details

Codecov Report

Attention: Patch coverage is 72.50000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 76.60%. Comparing base (cb69261) to head (2c2e2e5).

Files with missing lines Patch % Lines
dissect/target/loaders/ab.py 75.00% 1 Missing ⚠️
dissect/target/loaders/cb.py 0.00% 1 Missing ⚠️
dissect/target/loaders/cyber.py 75.00% 1 Missing ⚠️
dissect/target/loaders/local.py 92.85% 1 Missing ⚠️
dissect/target/loaders/log.py 66.66% 1 Missing ⚠️
dissect/target/loaders/mqtt.py 66.66% 1 Missing ⚠️
dissect/target/loaders/multiraw.py 75.00% 1 Missing ⚠️
dissect/target/loaders/overlay.py 75.00% 1 Missing ⚠️
dissect/target/loaders/ovf.py 75.00% 1 Missing ⚠️
dissect/target/loaders/raw.py 75.00% 1 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   76.65%   76.60%   -0.05%     
==========================================
  Files         316      316              
  Lines       27101    27140      +39     
==========================================
+ Hits        20774    20791      +17     
- Misses       6327     6349      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.