Fix AttributeError in syscache plugin

[JazzCore]

dissect.ntfs changes probably caused regression in syscache plugin that now raises following AttributeError for me:

$ target-query -q -f syscache  DC1.tar
Traceback (most recent call last):
  File "/home/user/test-venv/bin/target-query", line 8, in <module>
    sys.exit(main())
  File "/home/user/test-venv/lib/python3.9/site-packages/dissect/target/tools/utils.py", line 276, in wrapper
    return func(*args, **kwargs)
  File "/home/user/test-venv/lib/python3.9/site-packages/dissect/target/tools/query.py", line 384, in main
    raise e
  File "/home/user/test-venv/lib/python3.9/site-packages/dissect/target/tools/query.py", line 373, in main
    for record_entries in entry:
  File "/home/user/test-venv/lib/python3.9/site-packages/dissect/target/plugins/os/windows/syscache.py", line 78, in syscache
    full_path = self.target.fs.path("\\".join(["sysvol", mft.mft(file_segment).fullpath()]))
AttributeError: 'Mft' object has no attribute 'mft'

Also when MFT record is missing plugin raises following TypeError, PR also fixes this:

Traceback (most recent call last):
  File "/home/user/test-venv/bin/target-query", line 8, in <module>
    sys.exit(main())
  File "/home/user/test-venv/lib/python3.9/site-packages/dissect/target/tools/utils.py", line 276, in wrapper
    return func(*args, **kwargs)
  File "/home/user/test-venv/lib/python3.9/site-packages/dissect/target/tools/query.py", line 384, in main
    raise e
  File "/home/user/test-venv/lib/python3.9/site-packages/dissect/target/tools/query.py", line 373, in main
    for record_entries in entry:
  File "/home/user/test-venv/lib/python3.9/site-packages/dissect/target/plugins/os/windows/syscache.py", line 81, in syscache
    full_path = self.target.fs.path("\\".join(["sysvol", mft.ntfs.mft(file_segment).full_path()]))
TypeError: sequence item 1: expected str instance, NoneType found

[twiggler]

Dear @JazzCore ,

Thank you very much for your contribution to Dissect.
We will assign someone to review.

[twiggler]

mft already refers to a Mft instance, so I don't think we need the round trip and can shorten to
path = mft(file_segment).full_path().

We can make it even more concise:

Suggested change

	path = mft.ntfs.mft(file_segment).full_path()
	if path := mft(file_segment).full_path():
	full_path = self.target.fs.path("\\".join(["sysvol", path]))

Incidentally, when did you start experiencing this issue? I don't see any recent commits to dissect.ntfs which might cause this. Perhaps it never worked.

[twiggler]

Can you add a unit test to tests/plugins/os/windows/test_syscache.py?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.64%. Comparing base (cb69261) to head (d8da3ce).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
dissect/target/plugins/os/windows/syscache.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   76.65%   76.64%   -0.01%     
==========================================
  Files         316      316              
  Lines       27101    27103       +2     
==========================================
  Hits        20774    20774              
- Misses       6327     6329       +2     

Flag	Coverage Δ
unittests	76.64% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.