-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata fields to elastic adapter #121
Add metadata fields to elastic adapter #121
Conversation
307200b
to
fff4519
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 81.94% 83.67% +1.72%
==========================================
Files 34 34
Lines 3385 3394 +9
==========================================
+ Hits 2774 2840 +66
+ Misses 611 554 -57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Yun Zheng Hu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed some small inconsistencies for the http://
prefixing. See code suggestions.
After this it should be good to merge!
Co-authored-by: Yun Zheng Hu <[email protected]>
This PR adds metadata fields to the elastic adapter and repairs
elastic+[PROTOCOL]://
behaviour. It also enables users to authenticate to Elasticsearch with an API key.You can now write arbitrary metadata to the
document._source._record_metadata
dict using the following syntax:This will result in the following
_record_metadata
dict:Of course we can change
_meta_
to something else if that seems more appropriate for the flow.record project.