ULMS-1251 Fixed listener dropping for LockProvider

foxford · Apr 19, 2021 · 71883f3 · 71883f3
1 parent 4b376c2
commit 71883f3
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ulms/components",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "UI components library",
   "homepage": "https://github.com/netology-group/ulms-media-ui",
   "bugs": {

diff --git a/packages/drawing/package-lock.json b/packages/drawing/package-lock.json
diff --git a/packages/drawing/package.json b/packages/drawing/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ulms/ui-drawing",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "",
   "keywords": [
     "lerna"

diff --git a/packages/drawing/src/drawing.jsx b/packages/drawing/src/drawing.jsx
@@ -310,6 +310,8 @@ export class Drawing extends React.Component {
     }
 
     if (this.__lockProvider) {
+      this.__lockProvider.removeUpdateListener()
+
       this.__lockProvider = null
     }
 

diff --git a/packages/drawing/src/lock-provider.js b/packages/drawing/src/lock-provider.js
@@ -26,6 +26,10 @@ export class LockProvider {
     this.listener = fn
   }
 
+  removeUpdateListener () {
+    this.listener = undefined
+  }
+
   _updated (prev, next) {
     if (this.listener) {
       const changed = Boolean(!prev.length && next.length)

diff --git a/packages/drawing/src/lock-provider.test.js b/packages/drawing/src/lock-provider.test.js
@@ -19,5 +19,9 @@ describe('LockProvider', () => {
     provider.labels(['label_1', 'label_3'])
 
     expect(provider.isLocked('label_3')).toBe(true)
+
+    provider.removeUpdateListener()
+
+    expect(provider.listener).toBe(undefined)
   })
 })
-Original file line number
+Diff line change
@@ Expand Up / @@ -310,6 +310,8 @@ export class Drawing extends React.Component { @@
         }
         if (this.__lockProvider) {
+          this.__lockProvider.removeUpdateListener()
           this.__lockProvider = null
         }
@@ Expand Down @@