fix: fix: parseCheckArray checks for incremental field status

Fix: `parseCheckArray` checks for `incremental` field status.
foxhound87 · Jul 14, 2023 · 1d3ac21 · 1d3ac21
1 parent 67fef53
commit 1d3ac21
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
-# 6.3.4 (master)
+# 6.3.5 (master)
+- Fix: `parseCheckArray` checks for `incremental` field status.
+- Updated `semantic-release`
+
+- # 6.3.4 (master)
 - Fix: `isEmptyArray` reimplemented in `isArrayFromStruct` util function;
 - Removed lodash `_.isArray()` with `Array.isArray()`
 - Introduced `struct` prop in `makeField` method.

diff --git a/src/Field.ts b/src/Field.ts
@@ -283,7 +283,7 @@ export default class Field extends Base implements FieldInterface {
   /* ------------------------------------------------------------------ */
   /* COMPUTED */
 
-  get checkValidationErrors() {
+  get checkValidationErrors(): boolean {
     return (
       (this.validationAsyncData?.valid === false &&
         !_.isEmpty(this.validationAsyncData)) ||
@@ -322,15 +322,15 @@ export default class Field extends Base implements FieldInterface {
     }
   }
 
-  get actionRunning() {
+  get actionRunning(): boolean {
     return this.submitting || this.clearing || this.resetting;
   }
 
-  get checked() {
+  get checked(): boolean {
     return this.type === "checkbox" ? this.value : undefined;
   }
 
-  get value() {
+  get value(): any {
     return (typeof this._value === 'function' && !this.hasNestedFields)
       ? propGetter(this, FieldPropsEnum.value)
       : this.getComputedProp(FieldPropsEnum.value);
@@ -342,7 +342,7 @@ export default class Field extends Base implements FieldInterface {
       : this.getComputedProp(FieldPropsEnum.initial);
   }
 
-  get default() {
+  get default(): any {
     return this.$default
       ? toJS(this.$default)
       : this.getComputedProp(FieldPropsEnum.default);

diff --git a/src/models/FieldInterface.ts b/src/models/FieldInterface.ts
@@ -2,6 +2,7 @@ import BaseInterface from "./BaseInterface";
 import OptionsModel from "./OptionsModel";
 import StateInterface from "./StateInterface";
 export default interface FieldInterface extends BaseInterface {
+  hasInitialNestedFields: boolean;
   id: string | undefined;
   key: string | undefined;
   name: string | undefined;

diff --git a/src/parser.ts b/src/parser.ts
@@ -64,7 +64,7 @@ const parseArrayProp = (val: any, prop: string, removeNullishValuesInArrays: boo
 };
 
 const parseCheckArray = (field: any, value: any, prop: string, removeNullishValuesInArrays: boolean) => {
-  if (!field.fields.size && _.isObject(value) && _.isEmpty(value)) return [];
+  if (field.incremental && _.isObject(value) && _.isEmpty(value)) return [];
   return field.hasIncrementalKeys ? parseArrayProp(value, prop, removeNullishValuesInArrays) : value;
 }