cmd: Rename jx to jnx and split out flag version #36
Conversation
camh-
force-pushed
the
hermitise
branch
2 times, most recently
from
0d977f4 to
165c09a
Compare
There was a problem hiding this comment.
Looks good to me, but I haven't checked out and grepped this time.
I like jinx as the name is this tool and its evolution.
I wonder if the repo could/should be renamed to jnx as well and if it works be worth it removing the stdlib flag implementation altogether?
Rename `jx` to `jnx` as the jx binary name is already taken by jenkinsx. But jnx is also a better name since it sounds like jinx, and that's what you say when someone duplicates a word at the same time as you. jsonnet is about de-duplicating through templating, so jnx works. It can also be pronounced as a single syllable, which is also nice. Split the Go flag version of jnx into a completely separate program rather than having a `parseCLI()` function selected by build tags. The only reason for the flag version is to use the flag code path of jsonnext to demonstrate its use and to verify it works. jnx itself is going to evolve in future to contain subcommands which I do not intend to support in the flag version of jnx. So split it out so jnx can evolve on its own. Keep `jx.jsonnet` for now for backwards compatibility. It will be removed when I know I've removed all existing uses under that name.
I don't think so. The idea behind this repository was to provide an easy way to put jsonnet into your own app with some extensions that make it more useful. To that end, the stdlib flag package is still useful. And jnx is just an example of use of the libraries, not the purpose of the repo, so I do not want to rename the repo for that. |
|
Lgtm still |
Rename
jxtojnxas the jx binary name is already taken by jenkinsx.But jnx is also a better name since it sounds like jinx, and that's what
you say when someone duplicates a word at the same time as you. jsonnet
is about de-duplicating through templating, so jnx works. It can also be
pronounced as a single syllable, which is also nice.
Split the Go flag version of jnx into a completely separate program
rather than having a
parseCLI()function selected by build tags.The only reason for the flag version is to use the flag code path of
jsonnext to demonstrate its use and to verify it works. jnx itself is
going to evolve in future to contain subcommands which I do not intend
to support in the flag version of jnx. So split it out so jnx can evolve
on its own.
Keep
jx.jsonnetfor now for backwards compatibility. It will beremoved when I know I've removed all existing uses under that name.