Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine rate limiter #221

Merged
merged 2 commits into from
Nov 29, 2023
Merged

feat: refine rate limiter #221

merged 2 commits into from
Nov 29, 2023

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 28, 2023

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D\

  • use flush rate or reclaim rate to limit admission or reinsertion
  • remove reclaim rate limiter
  • remove rated random rate limit policy

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have passed make check and make test or make all in my local envirorment.

Related issues or PRs (optional)

close #200

- use flush rate to limit admission and reinsertion
- remove reclaim rate limiter
- remove rated random rate limit policy

Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx added the feature New feature or request label Nov 28, 2023
@MrCroxx MrCroxx self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (ca747d9) 77.77% compared to head (1b4ed56) 77.40%.

❗ Current head 1b4ed56 differs from pull request most recent head 0a7672b. Consider uploading reports for the commit 0a7672b to get more accurate results

Files Patch % Lines
foyer-storage/src/admission/rated_ticket.rs 0.00% 18 Missing ⚠️
foyer-storage/src/reinsertion/rated_ticket.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   77.77%   77.40%   -0.37%     
==========================================
  Files          50       47       -3     
  Lines        5799     5661     -138     
==========================================
- Hits         4510     4382     -128     
+ Misses       1289     1279      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

feat: admission policy based on real flush throughput
1 participant