Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refine foyer-experimental-bench structure #259

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jan 23, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have passed make check and make test or make all in my local envirorment.

Related issues or PRs (optional)

@MrCroxx MrCroxx added the feature New feature or request label Jan 23, 2024
@MrCroxx MrCroxx self-assigned this Jan 23, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) January 23, 2024 04:53
@MrCroxx MrCroxx disabled auto-merge January 23, 2024 04:53
@MrCroxx MrCroxx enabled auto-merge (squash) January 23, 2024 04:55
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (09b8b10) 75.38% compared to head (fcfded6) 74.03%.

Files Patch % Lines
foyer-experimental/src/metrics.rs 0.00% 114 Missing ⚠️
foyer-experimental/src/wal.rs 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   75.38%   74.03%   -1.36%     
==========================================
  Files          50       51       +1     
  Lines        6030     6140     +110     
==========================================
  Hits         4546     4546              
- Misses       1484     1594     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit e837fa9 into main Jan 23, 2024
10 of 11 checks passed
@MrCroxx MrCroxx deleted the xx/experimental/refactor-bench branch January 23, 2024 04:59
MrCroxx added a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant