Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use crate mixtrics for various metrics support #835

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jan 11, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

mixtrics: https://github.com/foyer-rs/mixtrics

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

foyer-rs/mixtrics#5

@MrCroxx MrCroxx added this to the v0.14 milestone Jan 11, 2025
@MrCroxx MrCroxx self-assigned this Jan 11, 2025
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-bench/src/main.rs 64.84% <ø> (ø)
foyer-common/src/metrics.rs 100.00% <100.00%> (ø)
foyer-memory/src/cache.rs 78.51% <ø> (ø)
foyer-memory/src/raw.rs 88.96% <ø> (ø)
foyer-storage/src/device/monitor.rs 80.90% <ø> (ø)
foyer-storage/src/large/batch.rs 85.29% <ø> (ø)
foyer-storage/src/large/flusher.rs 86.31% <ø> (ø)
foyer-storage/src/large/generic.rs 90.73% <ø> (ø)
foyer-storage/src/large/reclaimer.rs 85.36% <ø> (ø)
foyer-storage/src/large/recover.rs 90.90% <ø> (ø)
... and 11 more

@MrCroxx MrCroxx merged commit 81c7378 into main Jan 11, 2025
26 of 27 checks passed
@MrCroxx MrCroxx deleted the xx/mixtrics branch January 11, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant