Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upgrade mixtrics, add metrics model test #836

Merged
merged 1 commit into from
Jan 11, 2025
Merged

test: upgrade mixtrics, add metrics model test #836

merged 1 commit into from
Jan 11, 2025

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jan 11, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

foyer-rs/mixtrics#5
foyer-rs/mixtrics#7

@MrCroxx MrCroxx added the test label Jan 11, 2025
@MrCroxx MrCroxx added this to the v0.14 milestone Jan 11, 2025
@MrCroxx MrCroxx self-assigned this Jan 11, 2025
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-common/src/metrics.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@MrCroxx MrCroxx merged commit 44190ce into main Jan 11, 2025
27 checks passed
@MrCroxx MrCroxx deleted the xx/mtest branch January 11, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant