Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: reduce futures dependencies #851

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

tisonkun
Copy link
Contributor

AS IS

Copy link
Collaborator

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

Thank you for your contribution. 🥰

BTW. If the ffmt check failed. Please run make ffmt to fix, or run bundle make fast to run more fixes and checks locally.

.editorconfig Outdated
@@ -0,0 +1,11 @@
root = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add dot file that is specific to the editor in .gitignore.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-bench/src/main.rs 64.84% <ø> (ø)
foyer-common/src/countdown.rs 97.14% <ø> (ø)
foyer-common/src/future.rs 100.00% <ø> (ø)
foyer-common/src/tracing.rs 88.23% <100.00%> (+0.23%) ⬆️
foyer-memory/src/cache.rs 78.76% <ø> (ø)
foyer-storage/src/device/direct_fs.rs 87.42% <ø> (ø)
foyer-storage/src/engine.rs 57.00% <ø> (ø)
foyer-storage/src/large/flusher.rs 86.31% <ø> (ø)
foyer-storage/src/large/generic.rs 89.10% <ø> (-1.64%) ⬇️
foyer-storage/src/large/reclaimer.rs 85.36% <ø> (ø)
... and 8 more

Signed-off-by: tison <[email protected]>
@MrCroxx MrCroxx merged commit bc61fbd into foyer-rs:main Jan 31, 2025
33 checks passed
@tisonkun tisonkun deleted the reduce-futures-dep branch January 31, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants