Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop passing events to Promise.reject #39

Closed
wants to merge 1 commit into from
Closed

Stop passing events to Promise.reject #39

wants to merge 1 commit into from

Conversation

horttanainen
Copy link

image.onerror is passed an event, not an error:
getsentry/sentry-javascript#2546 (comment)
https://developer.mozilla.org/en-US/docs/Web/API/HTMLScriptElement

Passing reject directly to onerror causes the event to be thrown instead of an error:
getsentry/sentry-javascript#2546

@horttanainen
Copy link
Author

@fpapado I notice that there has not been an update for three years. Have you given up on this project?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant