Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using local_experimental as a default runner #2094

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Nov 21, 2024

closes #2093

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Nov 21, 2024 that may be closed by this pull request
@ychiucco ychiucco requested a review from tcompa November 21, 2024 10:24
@ychiucco ychiucco mentioned this pull request Nov 21, 2024
3 tasks
Copy link

github-actions bot commented Nov 21, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/admin
  v1.py
  fractal_server/app/routes/api/v1
  job.py
  fractal_server/app/runner/v1
  __init__.py
  fractal_server/app/runner/v1/_local
  _local_config.py
  fractal_server/app/runner/v2/_local_experimental
  _local_config.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link

github-actions bot commented Nov 21, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.9 0.8 1.12 0.0 0.0
dataset 0.9 0.8 1.12 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.9 0.89 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.2 10.2 1.00 0.6 0.6
power 379.1 383.7 0.99 366.2 366.2
dataset 147.4 145.9 1.01 134.0 134.0
project 43.2 46.2 0.94 47.2 47.2
job 29.0 26.2 1.11 32.4 32.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.6 6.5 1.02 2.2 2.2
power 134.0 138.0 0.97 655.0 652.4
dataset 138.1 135.1 1.02 910.8 905.6
project 44.0 47.1 0.93 285.5 283.9
job 36.4 36.5 1.00 226.3 225.0

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.8 7.8 1.00 0.1 0.1
power 7.6 7.5 1.01 0.1 0.1
dataset 7.6 7.5 1.01 0.1 0.1
project 9.4 9.5 0.99 2.3 2.3
job 7.6 7.6 1.00 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.2 6.4 0.97 0.8 0.8
power 6.1 6.1 1.00 0.8 0.8
dataset 6.4 6.4 1.00 0.8 0.8
project 6.2 6.1 1.02 0.8 0.8
job 6.1 6.1 1.00 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.6 7.5 1.01 1.6 1.6
power 7.7 7.5 1.03 1.6 1.6
dataset 7.5 7.2 1.04 1.6 1.6
project 7.4 7.3 1.01 1.6 1.6
job 7.5 7.6 0.99 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 14.4 11.9 1.21 0.8 0.8
power 26.1 27.6 0.95 29.1 29.1
dataset 19.5 19.6 0.99 16.7 16.7
project 22.6 22.7 1.00 21.0 21.0
job 11.8 11.5 1.03 0.8 0.8

POST /api/v2/project/3/dataset/407/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 152.8 150.8 1.01 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.3 5.1 1.04 0.2 0.2
power 4.9 4.9 1.00 0.2 0.2
dataset 4.8 4.9 0.98 0.2 0.2
project 4.8 4.8 1.00 0.2 0.2
job 4.9 4.9 1.00 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 263.1 263.0 1.00 0.2 0.2

@tcompa tcompa closed this Nov 21, 2024
@tcompa tcompa deleted the 2093-switch-to-using-local_experimental-as-a-default-runner branch November 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to using local_experimental as a default runner
2 participants