Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Upcoming 2.14 release #2287

Draft
wants to merge 134 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Upcoming 2.14 release #2287

wants to merge 134 commits into from

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Feb 18, 2025

closes #2285
closes #2292
closes #2294
closes #2301
closes #2306
closes #2317
closes #2314
closes #2329
closes #2326

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

Copy link

github-actions bot commented Feb 18, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.5 11.6 0.82 0.3 0.6
power 221.2 277.0 0.80 105.9 345.4
dataset 70.9 98.5 0.72 5.4 123.2
project 16.7 26.9 0.62 6.9 43.9
job 8.6 12.6 0.68 0.3 29.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.5 8.1 0.80 2.2 2.2
power 48.9 60.9 0.80 667.3 656.2
dataset 54.4 61.6 0.88 910.0 909.2
project 17.7 22.3 0.79 285.3 285.0
job 15.4 19.0 0.81 226.1 225.9

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.4 11.7 0.63 0.1 0.1
power 6.7 8.1 0.83 0.1 0.1
dataset 6.9 8.4 0.82 0.1 0.1
project 8.1 9.8 0.83 2.3 2.3
job 6.7 8.1 0.83 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.6 6.9 0.81 0.8 0.8
power 5.3 6.8 0.78 0.8 0.8
dataset 5.3 7.0 0.76 0.8 0.8
project 5.3 6.9 0.77 0.8 0.8
job 5.3 7.7 0.69 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.4 8.1 0.79 1.6 1.6
power 6.1 7.9 0.77 1.6 1.6
dataset 6.2 8.3 0.75 1.6 1.6
project 6.2 8.0 0.78 1.6 1.6
job 6.2 7.9 0.78 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 13.7 13.0 1.05 0.8 0.8
power 14.1 16.3 0.87 28.0 28.0
dataset 12.1 14.9 0.81 16.2 16.2
project 14.6 16.8 0.87 20.4 20.4
job 10.5 12.0 0.88 0.8 0.8

POST /api/v2/project/3/dataset/417/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 40.7 46.3 0.88 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.4 5.9 0.75 0.2 0.2
power 4.2 5.5 0.76 0.2 0.2
dataset 4.6 5.3 0.87 0.2 0.2
project 4.4 5.1 0.86 0.2 0.2
job 4.6 5.0 0.92 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 273.5 272.9 1.00 0.2 0.2

Copy link

github-actions bot commented Feb 18, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  config.py 738
  main.py
  fractal_server/app/routes/api/v2
  _aux_functions.py 441-464, 486-492
  history.py 127, 193, 200
  submit.py
  fractal_server/app/runner
  exceptions.py
  fractal_server/app/runner/executors
  base_runner.py 10, 37, 65, 75, 77, 96, 98, 104
  fractal_server/app/runner/executors/local
  _local_config.py
  fractal_server/app/runner/executors/slurm_common
  _batching.py
  _slurm_config.py
  fractal_server/app/runner/executors/slurm_ssh
  _executor_wait_thread.py
  _slurm_job.py
  executor.py
  fractal_server/app/runner/executors/slurm_sudo
  _check_jobs_status.py 13
  _subprocess_run_as_user.py
  runner.py 33-44, 60, 64, 68, 72, 84, 90-96, 102, 108, 164-212, 215, 218, 221, 225-243, 252-316, 320, 323-351, 356-378, 391-460, 472-544, 550-569
  fractal_server/app/runner/v2
  __init__.py
  _slurm_ssh.py
  _slurm_sudo.py 68
  fractal_server/ssh
  _fabric.py
  fractal_server/tasks/v2/local
  reactivate.py
  fractal_server/tasks/v2/ssh
  _utils.py
  collect.py
  deactivate.py
  reactivate.py
Project Total  

The report is truncated to 25 files out of 45. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

tcompa and others added 27 commits February 18, 2025 10:32
Introduce per-workflow history-based status endpoint
Improve handling of empty history, and expose new endpoint for per-workflowtask image list
…ry-item

delete historyitem when deleting dataset
ychiucco and others added 3 commits February 28, 2025 12:04
This reverts commit 1b0f492.
…page_size-in-apiv2project1statusimages-response

Review `page_size`
…actal_runner_tasks_include_image-obsolete-config-variable

Drop `FRACTAL_RUNNER_TASKS_INCLUDE_IMAGE`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment