Add different projection methods #814

jluethi · 2024-08-13T15:34:26Z

Closes #813

Checklist before merging

I added an appropriate entry to CHANGELOG.md

github-actions · 2024-08-13T17:26:48Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_tasks_core/tasks
copy_ome_zarr_hcs_plate.py	$This PR removes 1 from the number of statements in fractal_tasks_core/tasks/copy_ome_zarr_hcs_plate.py, taking it from 106 to 105.$	$This PR removes 1 from the number of statements missing coverage in fractal_tasks_core/tasks/copy_ome_zarr_hcs_plate.py, taking it from 3 to 2.$	$This PR adds 0.93 percentage points to the coverage rate in fractal_tasks_core/tasks/copy_ome_zarr_hcs_plate.py, taking it from 97.16% (103/106) to 98.09% (103/105).$	$In this PR, 3 new statements are added to fractal_tasks_core/tasks/copy_ome_zarr_hcs_plate.py, 3 of which are covered (100%).$
io_models.py	$This PR adds 2 to the number of statements in fractal_tasks_core/tasks/io_models.py, taking it from 57 to 59.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/tasks/io_models.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_tasks_core/tasks/io_models.py, which is 100% (59/59).$	$In this PR, 2 new statements are added to fractal_tasks_core/tasks/io_models.py, 2 of which are covered (100%).$
projection.py	$This PR adds 66 statements to fractal_tasks_core/tasks/projection.py. The file did not seem to exist on the base branch.$	$This PR adds 6 statements missing coverage to fractal_tasks_core/tasks/projection.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_tasks_core/tasks/projection.py is 90.9% (60/66). The file did not seem to exist on the base branch.$	$In this PR, 6 new statements are added to fractal_tasks_core/tasks/projection.py, 6 of which are covered (100%).$
projection_utils.py	$This PR adds 29 statements to fractal_tasks_core/tasks/projection_utils.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_tasks_core/tasks/projection_utils.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_tasks_core/tasks/projection_utils.py is 100% (29/29). The file did not seem to exist on the base branch.$	$In this PR, 30 new statements are added to fractal_tasks_core/tasks/projection_utils.py, 30 of which are covered (100%).$
Project Total

_{This report was generated by python-coverage-comment-action}

…it tests

…ection methods

…on task take the overwrite parameter from the init

jluethi · 2024-08-14T17:04:14Z

@silvbarb This PR is now finished and adds the different projection modes to the Fractal projection task. I renamed the task to Project Image (HCS Plate) to reflect that.

Will merge, release & add it to the Fractal server soon. You'll see the announcement in the #fractal Channel on slack :)

jluethi added 2 commits August 13, 2024 17:29

Add different projection methods

227dc5f

Move projection method choice into init function

97edbde

jluethi added 11 commits August 14, 2024 16:34

Improve type annotation

c895f2c

Rename maximum intensity projection to projection

fa953be

Move DaskProjectionMethod into utils file, add safe_sum function & un…

93aed9e

…it tests

Improve sum & mean handling, casting to type & add tests for all proj…

2442e7b

…ection methods

Update manifest

07e6076

Rename projection task to Project Image (HCS Plate) and make projecti…

35a1e1b

…on task take the overwrite parameter from the init

Update projection task docstring

2a6e8ad

Update tests to adapt to new overwrite in init_args

fa1734d

Update additional tests to adapt to new overwrite in init_args

d2cd450

Update Changelog

bb84d5c

Update Changelog

3cf1530

jluethi marked this pull request as ready for review August 14, 2024 17:04

jluethi merged commit 2a288e2 into main Aug 14, 2024
19 checks passed

jluethi deleted the 813_projections branch August 14, 2024 17:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add different projection methods #814

Add different projection methods #814

jluethi commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

jluethi commented Aug 14, 2024

Add different projection methods #814

Add different projection methods #814

Conversation

jluethi commented Aug 13, 2024 • edited Loading

Checklist before merging

github-actions bot commented Aug 13, 2024 • edited Loading

Coverage report

jluethi commented Aug 14, 2024

jluethi commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading