Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs table improvements #346

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Jobs table improvements #346

merged 6 commits into from
Nov 28, 2023

Conversation

zonia3000
Copy link
Collaborator

@zonia3000 zonia3000 commented Nov 27, 2023

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

Closes #344
Closes #345
Closes #343

Sorry, something went wrong.

Copy link

github-actions bot commented Nov 27, 2023

Coverage report
 ---------------------------------------|---------|----------|---------|---------|-------------------
File                                   | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
---------------------------------------|---------|----------|---------|---------|-------------------
All files                              |   40.05 |    24.27 |   41.15 |   42.95 |                   
 src                                   |       0 |        0 |       0 |       0 |                   
  hooks.server.js                      |       0 |        0 |       0 |       0 | 4-47              
 src/lib/common                        |   55.44 |    49.38 |   63.63 |   56.17 |                   
  component_utilities.js               |   64.61 |    63.15 |   69.23 |   64.28 | ...93-121,140-143 
  errors.js                            |   13.04 |     5.26 |      20 |   13.63 | 9-70,92           
  jschema_validation.js                |   84.61 |       60 |     100 |     100 | 25-33             
 src/lib/components/common             |   75.11 |    52.53 |   86.23 |   82.58 |                   
  ConfirmActionButton.svelte           |   78.73 |     42.1 |   97.67 |    89.9 | ...29-335,341,345 
  Modal.svelte                         |   80.14 |     64.1 |   80.43 |    86.2 | ...72,378-386,481 
  StandardDismissableAlert.svelte      |   60.24 |    47.61 |      75 |   61.64 | ...34,139-140,158 
  StandardErrorAlert.svelte            |       0 |        0 |     100 |       0 | 4-27              
 src/lib/components/common/filterable  |   72.13 |       30 |      75 |      80 |                   
  Th.svelte                            |   72.13 |       30 |      75 |      80 | ...53,75-77,86-89 
 src/lib/components/common/jschema     |    6.77 |     7.92 |    7.58 |    7.34 |                   
  ArrayProperty.svelte                 |       0 |        0 |       0 |       0 | 6-555             
  BooleanProperty.svelte               |       0 |        0 |       0 |       0 | 5-265             
  JSchema.svelte                       |       0 |        0 |       0 |       0 | 34-578            
  NumberProperty.svelte                |       0 |        0 |       0 |       0 | 5-238             
  ObjectProperty.svelte                |       0 |        0 |       0 |       0 | 6-839             
  PropertiesBlock.svelte               |       0 |        0 |       0 |       0 | 6-348             
  PropertyDescription.svelte           |       0 |        0 |       0 |       0 | 4-139             
  PropertyDiscriminator.svelte         |       0 |        0 |       0 |       0 | 8-576             
  SchemaInput.svelte                   |       0 |        0 |     100 |       0 | 4-58              
  StringProperty.svelte                |       0 |        0 |       0 |       0 | 5-235             
  schema_management.js                 |   86.97 |    71.42 |   86.84 |   86.41 | ...77,294-304,364 
 src/lib/components/jobs               |   78.49 |     51.1 |   72.12 |   80.94 |                   
  JobInfoModal.svelte                  |   88.24 |    34.54 |   82.97 |   92.12 | ...14-624,636-637 
  JobLogsModal.svelte                  |   74.52 |    30.76 |   85.71 |      80 | ...56,176,191-192 
  JobsList.svelte                      |   75.73 |     54.4 |   67.07 |   77.45 | ...2493,2519-2520 
  StatusBadge.svelte                   |    90.9 |    59.09 |     100 |   91.89 | 12,61,65          
 src/lib/components/projects           |   61.88 |    39.73 |   70.51 |   67.73 |                   
  CreateUpdateDatasetModal.svelte      |   65.51 |    53.09 |   74.85 |    72.6 | ...1939,1981-1982 
  ProjectDatasetsList.svelte           |   83.33 |    52.63 |    87.5 |   88.12 | ...31,496-498,514 
  ProjectInfoModal.svelte              |    38.8 |     11.9 |   60.78 |   42.43 | ...86,614,633-635 
  ProjectsList.svelte                  |   74.29 |    47.72 |   82.92 |   80.25 | ...95-597,610-611 
  WorkflowImport.svelte                |   48.92 |    32.05 |      40 |   54.69 | ...97,409-415,439 
  WorkflowsList.svelte                 |   55.19 |       25 |   60.37 |   60.16 | ...07-736,763-764 
 src/lib/components/tasks              |   25.14 |    16.08 |   36.16 |      27 |                   
  TaskCollection.svelte                |   56.83 |    39.49 |   65.27 |    62.8 | ...1204,1213-1224 
  TaskCollectionLogsModal.svelte       |   42.04 |     4.54 |   58.33 |   46.75 | ...36-154,166-178 
  TaskEditModal.svelte                 |    5.64 |     6.66 |    21.5 |     5.7 | ...1163-1256,1267 
  TaskInfoModal.svelte                 |     5.7 |     3.24 |   20.73 |    6.34 | ...40,864,874-892 
 src/lib/components/workflow           |   21.27 |     14.9 |   21.87 |   21.35 |                   
  ArgumentForm.svelte                  |       0 |        0 |       0 |       0 | 15-128            
  ArgumentsSchema.svelte               |       0 |        0 |       0 |       0 | 8-350             
  MetaPropertiesForm.svelte            |       0 |        0 |       0 |       0 | 16-141            
  VersionUpdate.svelte                 |   14.69 |     11.7 |    2.22 |   13.66 | ...5,279,283-1407 
  WorkflowTaskSelection.svelte         |   52.26 |    33.33 |   66.66 |   55.91 | ...18,665-692,710 
  task_form_utils.js                   |       0 |        0 |       0 |       0 | 19-122            
  version-checker.js                   |    90.9 |    88.88 |     100 |    90.9 | 22                
 src/lib/components/workflow/common    |       0 |        0 |       0 |       0 |                   
  FormBaseEntry.svelte                 |       0 |        0 |       0 |       0 | 7-790             
  FormBuilder.svelte                   |       0 |        0 |       0 |       0 | 5-129             
  FormStructure.svelte                 |       0 |        0 |       0 |       0 | 9-1152            
  NewEntryProperty.svelte              |       0 |        0 |       0 |       0 | 3-727             
 src/lib/server/api/v1                 |       0 |        0 |       0 |       0 |                   
  auth_api.js                          |       0 |        0 |       0 |       0 | 11-62             
  dataset_api.js                       |       0 |        0 |       0 |       0 | 10-19             
  monitoring_api.js                    |       0 |        0 |       0 |       0 | 12-24             
  project_api.js                       |       0 |        0 |       0 |       0 | 12-176            
  task_api.js                          |       0 |        0 |       0 |       0 | 10-22             
  workflow_api.js                      |       0 |        0 |       0 |       0 | 10-68             
 src/lib/stores                        |      75 |      100 |     100 |      75 |                   
  authStores.js                        |       0 |      100 |     100 |       0 | 3                 
  errorStores.js                       |     100 |      100 |     100 |     100 |                   
  projectStores.js                     |     100 |      100 |     100 |     100 |                   
  serverStores.js                      |       0 |      100 |     100 |       0 | 3                 
  taskStores.js                        |     100 |      100 |     100 |     100 |                   
 src/routes                            |   76.16 |     47.5 |   61.11 |   80.87 |                   
  +layout.server.js                    |       0 |        0 |       0 |       0 | 6-38              
  +layout.svelte                       |   95.58 |    66.66 |     100 |      98 | 3                 
  +page.svelte                         |   82.59 |       44 |   95.65 |    90.8 | ...,49,52,350-363 
  proxy.js                             |       0 |        0 |       0 |       0 | 7-92              
 src/routes/api/[...path]              |       0 |      100 |     100 |       0 |                   
  +server.js                           |       0 |      100 |     100 |       0 | 6-9               
 src/routes/auth/[...path]             |       0 |      100 |     100 |       0 |                   
  +server.js                           |       0 |      100 |     100 |       0 | 6-9               
 src/routes/auth/login                 |   59.52 |    52.94 |       0 |   58.06 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-22              
  +page.svelte                         |   69.44 |    52.94 |     100 |      72 | 12,24-32,99-108   
  cookie.js                            |       0 |      100 |       0 |       0 | 17-28             
 src/routes/auth/login/oauth2          |       0 |        0 |       0 |       0 |                   
  +layout.server.js                    |       0 |        0 |       0 |       0 | 6-38              
  +page.svelte                         |       0 |      100 |     100 |       0 | 1                 
 src/routes/auth/logout                |   63.63 |       50 |      80 |   63.15 |                   
  +page.svelte                         |   63.63 |       50 |      80 |   63.15 | 6-16,24           
 src/routes/auth/token/logout          |       0 |      100 |       0 |       0 |                   
  +server.js                           |       0 |      100 |       0 |       0 | 13-26             
 src/routes/jobs                       |   46.91 |     6.25 |      40 |   52.85 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 6-25              
  +page.svelte                         |   55.07 |     6.25 |   61.53 |   60.65 | ...-57,92-105,124 
 src/routes/projects                   |   65.06 |     37.5 |   64.28 |   64.93 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-21              
  +page.svelte                         |   71.05 |     37.5 |   81.81 |   71.42 | ...,53-62,105-108 
 src/routes/projects/[projectId]       |   75.28 |     37.5 |   84.37 |   78.93 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 4-12              
  +page.svelte                         |   76.13 |     37.5 |   85.71 |   79.94 | ...23-655,661-662 
 ...s/[projectId]/datasets/[datasetId] |       0 |        0 |       0 |       0 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 7-14              
  +page.svelte                         |       0 |        0 |     100 |       0 | 6-185             
 ...[projectId]/workflows/[workflowId] |   37.12 |    24.78 |   46.27 |   40.88 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-18              
  +page.svelte                         |   37.18 |    24.78 |   46.36 |   40.96 | ...5522,5533-5534 
 ...ectId]/workflows/[workflowId]/jobs |   44.49 |    21.21 |   44.44 |   48.75 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 6-28              
  +page.svelte                         |   47.19 |    21.21 |      60 |    51.3 | ...61-266,283-295 
 src/routes/sandbox                    |       0 |        0 |       0 |       0 |                   
  +layout.js                           |       0 |        0 |       0 |       0 | 4-5               
 src/routes/sandbox/jsonschema         |       0 |      100 |     100 |       0 |                   
  +page.svelte                         |       0 |      100 |     100 |       0 | 5-15              
 src/routes/tasks                      |   57.48 |     6.25 |    28.3 |   63.11 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 4-5               
  +page.svelte                         |   57.59 |     6.25 |   28.84 |   63.25 | ...1134,1175-1282 
---------------------------------------|---------|----------|---------|---------|-------------------
 

@zonia3000 zonia3000 merged commit 0c9e987 into main Nov 28, 2023
@zonia3000 zonia3000 deleted the jobs-table-fix branch November 28, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant